Skip to content

Fixes tstart not updating in stingray.Lightcurve.shift #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ankitkhushwaha
Copy link
Contributor

@ankitkhushwaha ankitkhushwaha commented Apr 6, 2025

fixes issues #911, #916

Implemented all the required changes.

@ankitkhushwaha ankitkhushwaha force-pushed the lighcurve branch 2 times, most recently from 79b24f2 to 03942ab Compare April 6, 2025 04:23
@ankitkhushwaha ankitkhushwaha changed the title Fixes issue with None in stingray.lighcurve Handle None values in Lightcurve init & fix tstart logic in shift method Apr 6, 2025
@ankitkhushwaha ankitkhushwaha changed the title Handle None values in Lightcurve init & fix tstart logic in shift method Handle None values in Lightcurve.init & fix tstart logic in shift method Apr 6, 2025
@ankitkhushwaha ankitkhushwaha changed the title Handle None values in Lightcurve.init & fix tstart logic in shift method Handle None err_dist in Lightcurve.init & fix tstart logic in shift method Apr 6, 2025
Copy link

codecov bot commented Apr 12, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (cc4c259) to head (514e5e3).

Files with missing lines Patch % Lines
stingray/lightcurve.py 83.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cc4c259) and HEAD (514e5e3). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (cc4c259) HEAD (514e5e3)
5 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #912       +/-   ##
===========================================
- Coverage   91.53%   79.77%   -11.76%     
===========================================
  Files          48       48               
  Lines        9770     9782       +12     
===========================================
- Hits         8943     7804     -1139     
- Misses        827     1978     +1151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ankitkhushwaha ankitkhushwaha changed the title Handle None err_dist in Lightcurve.init & fix tstart logic in shift method Fixes tstart not updating in stingray.Lightcurve.shift Apr 12, 2025
@Sauravroy34
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants