check if the image is locally, otherwise pull it #22
Conversation
|
awesome |
check if the image is locally, otherwise pull it
| if (err) return done(err); | ||
|
|
||
| var found = images.some(function (img) { | ||
| return ~img.RepoTags.indexOf(fullname); |
There was a problem hiding this comment.
that ~ is too clever :P i had to google this. learn something new everyday...
There was a problem hiding this comment.
Yeah I personally really don't like it because it obscures the logic....
There was a problem hiding this comment.
let's make it clearer next time we're working in the file, i think it's fine for now -- anyone seriously looking at this code is gonna google and learn
There was a problem hiding this comment.
Yes I agree with @jaredly, but at the same time my brain reads ~....indexOf(x) as contains. Because I've read a lot of javascript and node modules and it is a very common trick.
I hope this succeed domenic/Array.prototype.contains some day.
|
To be honest, I don't understand why this is so hard with dockerode, the run command from the cli automatically fetch the image. Seems, that's not the case with the remote api |
|
@jfromaniello the docker remote api is just way more granular than the docker cli. dockerode does a fantastic job wrapping the api in my opinion |
With this change it will work similar to
docker runcommand.If the image is not locally it will pull it.