Skip to content

Rock tiles are no longer solid. FINALLY! #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Semphriss
Copy link
Member

NOTE: No level has been edited in this commit. Some levels (such as the first level of the forest world) might have buggy graphics or even might be rendered impossible at all due to this.

NOTE: No level has been edited in this commit. Some levels (such as the first level of the forest world) might have buggy graphics or even might be rendered impossible at all due to this.
@Ordoviz
Copy link
Contributor

Ordoviz commented Dec 19, 2020

The people have spoken.

@tobbi
Copy link
Member

tobbi commented Dec 19, 2020

Since making stones non-solid will impact existing levels to quite an extent, I will not merge this. Sorry 'bout that.

@tobbi tobbi closed this Dec 19, 2020
@Semphriss
Copy link
Member Author

Reopened after internal discussion

And this time, marked as WIP to make it clear I intend to make sure no level relied on rocks being solid, and to fix those that did.

@Semphriss Semphriss reopened this Dec 19, 2020
@Semphriss Semphriss marked this pull request as draft December 19, 2020 18:04
@Semphriss Semphriss marked this pull request as ready for review January 4, 2021 17:03
@Semphriss
Copy link
Member Author

Ready for review; all forest levels have been adapted. Let me know if something else needs attention.

@tobbi tobbi merged commit 6c22612 into SuperTux:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants