-
-
Notifications
You must be signed in to change notification settings - Fork 516
WASM/Emscripten port (SuperTux in the browser) #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0b478d
to
ed1d925
Compare
5bf0516
to
430f5da
Compare
FIXED: Now audio plays FIXME: Whenever a sound stops playing (like the music stopping when entering a worldmap, or, on the main manu, when SuperTux jumps and the jump sound finished playing), OpenAL crashes the game with 'TypeError: src.audioQueue is undefined', see emscripten-core/emscripten#13797
FIXED: OpenAL no longer crashes the game (dirty fix) - The game now uses a custom HTML template - The game now follows the size of the screen (changeable in the option menu) - Adapted CI to use the custom template
…removed a now-untrue line at launch (WASM)
FIXME: Does not compile; unique pointers require the appropriate #includes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO's & FIXME's
Known issues
User experience:
Code quality:
Potential additions