Recent AppVeyor builds throw errors constantly on Win 7 & 10 when accessing any menus with a game running.

[ghost]

edit: Hijacking OP to say that I filed a support ticket with GitHub re: the spurious cross-references, and was told there's still no way to remove them—apart from deleting the issue, which I'm hesitant to do. So while it's weird that I can't edit or unhide certain comments, being able to wouldn't help here. --yoshi

---

Recent AppVeyor builds throw errors constantly on Win 7 & 10 when accessing any menus with a game running.

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.Assembly.GetTypes()
   at BizHawk.Client.EmuHawk.ToolManager.<>c.<.cctor>b__57_0()
   at System.Lazy`1.CreateValue()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Lazy`1.get_Value()
   at BizHawk.Client.EmuHawk.ToolManager.IsAvailable(Type tool)
   at BizHawk.Client.EmuHawk.MainForm.ToolsSubMenu_DropDownOpened(Object sender, EventArgs e)
   at System.Windows.Forms.ToolStripDropDownItem.OnDropDownOpened(EventArgs e)
   at System.Windows.Forms.ToolStripDropDown.OnOpened(EventArgs e)
   at System.Windows.Forms.ToolStripDropDown.SetVisibleCore(Boolean visible)
   at System.Windows.Forms.ToolStripDropDown.Show()
   at System.Windows.Forms.ToolStripDropDownItem.ShowDropDownInternal()
   at System.Windows.Forms.ToolStripDropDownItem.ShowDropDown(Boolean mousePush)
   at System.Windows.Forms.ToolStripItem.HandleMouseDown(MouseEventArgs e)
   at System.Windows.Forms.ToolStrip.OnMouseDown(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.MenuStrip.WndProc(Message& m)
   at MenuStripEx.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

[YoshiRulz]

This affects every build since 0e9cc43 when run on Windows—it wasn't noticed by myself or others because VS prevents the error dialog from appearing.

---

I thought that this prevented ReflectionTypeLoadExceptions, but clearly not in every case...
https://github.com/TASVideos/BizHawk/blob/520ba97caaeebb5a3624aab3edd9879d7ff428a4/BizHawk.Client.EmuHawk/Program.cs#L76-L77

[jdpurcell]

@jjfmz42015 Can you please try the latest build and paste the detailed error message here? I didn't fix anything, but added better logging to hopefully help us locate the problem.

EDIT: These 2 builds are worth trying. First is my logging enhancement and the second was an attempted actual fix (which unfortunately removed the logging for some reason):
https://ci.appveyor.com/project/zeromus/bizhawk-udexo/builds/28534573
https://ci.appveyor.com/project/zeromus/bizhawk-udexo/builds/28535882

[jdpurcell]

@jjfmz42015 Aha, makes sense now. The full build script places the dlls in a separate folder and the code has some magic to deal with them not being in the same folder as the main exe. The commit that broke this was trying to load dlls without the magic part. Thanks for reporting and helping us troubleshoot!

[ghost]

@jdpurcell

Thanks for explaining.

Thanks for the help, thanks to all of you for this emulator.

Use it alot here.

Im always glad if I can help in some way.