Skip to content

Use new StarRecord class for StarStore objects #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

C0rn3j
Copy link
Collaborator

@C0rn3j C0rn3j commented May 18, 2025

Refactor StarStore to use class object instead of a list.

Removes flags parameter as it was only used for loving a track, now there's a boolean.

Removes an unused album variable.

Fixes breaking really old migrations, as star_store wasn't being loaded before migration was being processed.

Fixes a bug where the list had an incorrect amount of values, breaking loving a track:

2025-05-18 01:57:27 [CRITICAL] [  t_main  ] [1069.17647152688, '', 0] (t_main.py:15846)
Exception in thread Thread-16 (love):
Traceback (most recent call last):
  File "/usr/lib/python3.13/threading.py", line 1041, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/usr/lib/python3.13/threading.py", line 992, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/tauon/t_modules/t_main.py", line 15846, in love
    star[3] = time.time()
    ~~~~^^^
IndexError: list assignment index out of range

@C0rn3j C0rn3j force-pushed the starfactor branch 5 times, most recently from caf8b44 to 1d48949 Compare May 18, 2025 10:10
@C0rn3j C0rn3j marked this pull request as ready for review May 18, 2025 10:11
@C0rn3j C0rn3j force-pushed the starfactor branch 2 times, most recently from 028fcfe to ea8f7df Compare May 18, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant