feat(ARCH-349/forms): lazyload react ace #3258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and there is no UMD for it
…nd/ui into jmfrancois/chore/cmf-upgrade-sentry
This reverts commit 86a80df.
|
Size Change: -24.4 kB (-1%) Total Size: 2.25 MB
ℹ️ View Unchanged
|
…:Talend/ui into jmfrancois/feat/forms-lazyload-react-ace
1 similar comment
1 similar comment
frassinier
reviewed
Mar 30, 2021
| clearInterval(intervalId); | ||
| resolve(window[varName]); | ||
| } | ||
| }, 200); |
There was a problem hiding this comment.
I'm not confident there is no error management at this point
There was a problem hiding this comment.
Yes but I have no way to track status of the loading
The only option is to put some console.log at some pace may be ?
There was a problem hiding this comment.
It could be neat, with a timeout?
frassinier
reviewed
Mar 30, 2021
| "enableLiveAutocompletion": true, | ||
| "enableSnippets": true, | ||
| <AceCodeWidget> | ||
| <UNDEFINED |
There was a problem hiding this comment.
Can we add a displayName?
packages/forms/src/deprecated/widgets/CodeWidget/CodeWidget.component.js
Outdated
Show resolved
Hide resolved
| name: 'react-ace', | ||
| varName: 'ReactAce', | ||
| version: '6.2.0', | ||
| path: '/dist/react-ace.min.js', |
There was a problem hiding this comment.
Could be neat to use the mapping from DynamicWebpackPlugin instead?
| "enableLiveAutocompletion": true, | ||
| "enableSnippets": true, | ||
| > | ||
| <UNDEFINED |
There was a problem hiding this comment.
May be just inject the global var before the tests are runned should fix that
packages/components/src/index.js
Outdated
| @@ -22,6 +22,7 @@ import CollapsiblePanel from './CollapsiblePanel'; | |||
| import ConfirmDialog from './ConfirmDialog'; | |||
| import Datalist from './Datalist'; | |||
| import { ModelViewer, RecordsViewer } from './DataViewer'; | |||
| import { importFromCDN } from './importFromCDN'; | |||
There was a problem hiding this comment.
What do you think about a babel macro instead? Defined in TUI Scripts?
There was a problem hiding this comment.
AFAIK macro are good when you have few lines of code here I am not sure of the qtt
1 similar comment
…:Talend/ui into jmfrancois/feat/forms-lazyload-react-ace
1 similar comment
jmfrancois
changed the title
|
super seed by #3692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
react-ace is downloaded (part of dependencies.json manifest) while it will may be never used.
What is the chosen solution to this problem?
POC a way to lazy load UMD.
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change