Skip to content

Add context menu "Open in Terminal" option #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/4.0
Choose a base branch
from

Conversation

TranceLove
Copy link
Collaborator

@TranceLove TranceLove commented Jul 6, 2024

Description

Adds option to open specified folder in terminal app.

Supports TermOne Plus, Termux. Jack Palovich's Android Terminal is also supported in code, but not thoroughly tested since it's no longer in development.

Expected user to do all the configuration at Terminal app's own side - like this, the most Amaze can do is check for corresponding app permission and prompt user to grant.

Issue tracker

Fixes #2666

Automatic tests

  • Added test cases

Manual tests

  • Done

  • Device: Nexus 4 emulator

  • OS: Android 8

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove
Copy link
Collaborator Author

TranceLove commented Jul 6, 2024

Pending tasks:

  • Fix codacy complaints

@TranceLove TranceLove force-pushed the feature/2666 branch 2 times, most recently from d0c3440 to d4ed856 Compare July 6, 2024 09:28
@TranceLove TranceLove marked this pull request as ready for review July 6, 2024 10:05
@VishalNehra
Copy link
Member

Pressing on the option 'open in terminal' does nothing on me device
I just have below logs that was showing error level not sure how helpful it would be

2024-07-18 02:45:05.277 3045-3951 UAH_JNI pid-3045 E uah_rule_ctrl id = 0x1 ,value = pkgName:com.amaze.filemanager.debug,type:1,activityName:com.amaze.filemanager.debug/com.amaze.filemanager.ui.activities.MainActivity,isFocused:true|pkgName:com.android.launcher,type:1,activityName:com.android.launcher/.Launcher,isFocused:false

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • app/src/main/AndroidManifest.xml: Language not supported

TERMONE_PLUS -> {
Intent().also {
it.action = "$TERMONE_PLUS.RUN_SCRIPT"
it.setClassName(TERMONE_PLUS, "$ANDROID_TERM.RunScript")
Copy link
Preview

Copilot AI Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the TERMONE_PLUS branch, the class name is set using the ANDROID_TERM constant instead of TERMONE_PLUS. Update it to use the correct package name for Termone Plus, e.g., "$TERMONE_PLUS.RunScript".

Suggested change
it.setClassName(TERMONE_PLUS, "$ANDROID_TERM.RunScript")
it.setClassName(TERMONE_PLUS, "$TERMONE_PLUS.RunScript")

Copilot uses AI. Check for mistakes.

@VishnuSanal VishnuSanal added the pr-requested-changes this PR is awaiting an update from the author label Apr 18, 2025
@EmmanuelMess EmmanuelMess added pr-awaiting-initial-review this PR is awaiting for an initial review and removed pr-requested-changes this PR is awaiting an update from the author labels Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-awaiting-initial-review this PR is awaiting for an initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Open in Terminal" button
4 participants