-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add context menu "Open in Terminal" option #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/4.0
Are you sure you want to change the base?
Conversation
Pending tasks:
|
d0c3440
to
d4ed856
Compare
Pressing on the option 'open in terminal' does nothing on me device
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- app/src/main/AndroidManifest.xml: Language not supported
TERMONE_PLUS -> { | ||
Intent().also { | ||
it.action = "$TERMONE_PLUS.RUN_SCRIPT" | ||
it.setClassName(TERMONE_PLUS, "$ANDROID_TERM.RunScript") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the TERMONE_PLUS branch, the class name is set using the ANDROID_TERM constant instead of TERMONE_PLUS. Update it to use the correct package name for Termone Plus, e.g., "$TERMONE_PLUS.RunScript".
it.setClassName(TERMONE_PLUS, "$ANDROID_TERM.RunScript") | |
it.setClassName(TERMONE_PLUS, "$TERMONE_PLUS.RunScript") |
Copilot uses AI. Check for mistakes.
Description
Adds option to open specified folder in terminal app.
Supports TermOne Plus, Termux. Jack Palovich's Android Terminal is also supported in code, but not thoroughly tested since it's no longer in development.
Expected user to do all the configuration at Terminal app's own side - like this, the most Amaze can do is check for corresponding app permission and prompt user to grant.
Issue tracker
Fixes #2666
Automatic tests
Manual tests
Done
Device: Nexus 4 emulator
OS: Android 8
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug
./gradlew spotlessCheck