Fix webpage tests #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glob was not working when tests are run in tox, because current path was not the same
handling differences are ignored for now
Merged
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 2 2
Lines 92 92
Branches 17 17
=======================================
Hits 90 90
Misses 2 2Continue to review full report at Codecov.
|
lopuhin
approved these changes
Nov 14, 2018
Co-Authored-By: kmike <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_webpages was not executed in tox (and on Travis) because glob returned empty results. Also, they were broken in Python 2.