-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Support simpleomp on Windows with MSVC #5683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jiang-Weibo
commented
Sep 5, 2024
- Modify the CMakeLists.txt on the top level to leverage openmp on MSVC
- Support simpleomp on MSVC
- Test the results using the existed tests folder
s2496214 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5683 +/- ##
===========================================
- Coverage 95.16% 94.42% -0.75%
===========================================
Files 743 464 -279
Lines 252233 133625 -118608
===========================================
- Hits 240043 126175 -113868
+ Misses 12190 7450 -4740 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The binary size change of libncnn.so (bytes)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables support for simpleomp on Windows with MSVC by adding Windows-specific branches in the source code and updating the CMake and GitHub Actions workflow files to configure and test the MSVC build.
- Introduces _WIN32-specific typedefs, initialization, and task dispatch code in src/simpleomp.cpp.
- Adds new build and test steps in the Windows workflow to compile and run the simpleomp configuration.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/simpleomp.cpp | Adds Windows/MSVC branches for OpenMP support and task dispatch. |
.github/workflows/windows.yml | Introduces build and test steps for the x64-simpleomp configuration. |
Files not reviewed (1)
- src/CMakeLists.txt: Language not supported
Hello @Jiang-Weibo , Thank you very much for your outstanding contribution to Once again, I really appreciate your great work, and I look forward to seeing more of your contributions in the community! |