add_ functions do not all have roxygen comments

[allaway]

Perhaps I'm missing something obvious, but is there any reason that golem::add_fct/add_utils does not add a roxygen comment section to the resulting file like add_module does to the module files?
It seems like it would be helpful to add this for parity across the add_ functions and to encourage good documentation practices.

[allaway]

Related to #165

[ColinFay]

You're right, there should be roxygen tags here.

Would you be willing to PR that?
I think we should do this in the spirit of the way add_module() works https://github.com/ThinkR-open/golem/blob/dev/R/add_modules.R#L71 (i.e with an export parameter to the function)

[novica]

@ColinFay I would like to try to do this if no one is working on it.

My thinking is that first we should move

 write_there <- function(...){
      write(..., file = where, append = TRUE)
    } 

from add_modules.R so it can be reused to utils.R.
and then modify add_modules and add_r_files accordingly.
Does this make sense?

[allaway]

Apologies for never following up on this, I intended to but it got lost in the shuffle. @novica - I am not working on this, so there won't be duplicated effort :) Thanks for doing this!

…

On Thu, May 7, 2020 at 12:45 PM novica ***@***.***> wrote: @ColinFay <https://github.com/ColinFay> I would like to try to do this if no one is working on it. My thinking is that first we should move write(..., file = where, append = TRUE) } ``` from add_modules.R so it can be reused to utils.R. and then modify add_modules and add_r_files accordingly. Does this make sense? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#330 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE3WNSGPR46KVQAI5PJU63DRQMFXJANCNFSM4KJ3APNA> .

[novica]

Maybe: #525

[ColinFay]

This has been implemented in 4fc81ba :)

Thanks everyone for the ideas and for contributing 🤘

[allaway]

Thanks so much, and my apologies for totally forgetting about trying to tackle this!

…

On Thu, Feb 4, 2021 at 1:21 PM Colin Fay ***@***.***> wrote: This has been implemented in 4fc81ba <4fc81ba> :) Thanks everyone for the ideas and for contributing 🤘 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#330 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE3WNSHMH5GHSIZPXWBKP5TS5MFURANCNFSM4KJ3APNA> .