735 check module exists before adding new related files #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fct_, utils_, js and such extra files are optionally added only after module main file has been created.
If not an error is thrown.
add_r_files() and use_module_test() will now both remove the "mod_" and file extension if the module file name is passed as argument instead of module name.
ALanguillaume
commented
Oct 29, 2021
| expect_true(file.exists("R/mod_ploup_utils_utils.R")) | ||
|
|
||
|
|
||
| remove_file(mod_ploup_file) |
There was a problem hiding this comment.
In general I am not sure I followed your testing routine properly. Especially when it comes to delete existing files.
We might need to talk about that.
ColinFay
deleted the
735-check-module-exists-before-adding-new-related-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #735
add_fct(),add_utils()anduse_module_test()are now all:mod_something.R) instead of the module name (something).