Skip to content

fix: unit test requires dependencies in suggests #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

statnmap
Copy link
Contributor

tags: fix, test

Why?

  • On a fresh install, you may not have all dependencies to run all unit tests. For instance with {dockerfiler} here

What?

  • Update unit tests for skip if not dockerfiler
  • Update unit test for functions needing {pkgload} which is not loaded by default
  • pkg_version as changed its format. Need to change as character for correct test

tags: fix, test

Why?

- On a fresh install, you may not have all dependencies to run all unit
  tests. For instance with {dockerfiler} here

What?

- Update unit tests for skip if not dockerfiler
- Update unit test for functions needing {pkgload} which is not loaded
  by default
- pkg_version as changed its format. Need to change as character for
  correct test
@statnmap statnmap requested a review from ColinFay September 15, 2022 09:39
@ColinFay ColinFay changed the base branch from master to dev September 15, 2022 09:44
@ColinFay ColinFay merged commit 9a809bb into dev Oct 13, 2022
@ColinFay ColinFay deleted the fix-fresh-installs branch February 28, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants