Skip to content

It's an invalid check null with SEC_WEB_SOCKET_KEY . #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dota17 opened this issue Aug 1, 2020 · 0 comments · Fixed by #1054
Closed

It's an invalid check null with SEC_WEB_SOCKET_KEY . #1053

dota17 opened this issue Aug 1, 2020 · 0 comments · Fixed by #1054
Labels
Bug
Milestone
Release 1.5.2

Comments

@dota17
Copy link
Contributor

dota17 commented Aug 1, 2020 •
edited
Loading

Describe the bug
It's an invalid check null with SEC_WEB_SOCKET_KEY in Draft_6455.postProcessHandshakeResponseAsServer(request, response), maybe we can change to check the blank .
To Reproduce
If the field of SEC_WEB_SOCKET_KEY was null, it returned the blank.
returnBlank_20200801095312
It's only an null check with SEC_WEB_SOCKET_KEY, but the return value is a blank:
nullCheck_20200801095235

Maybe we need to add the blank checking:
CheckBlank_20200801100310
dota17 added a commit to dota17/Java-WebSocket that referenced this issue Aug 1, 2020
@dota17
fix issue TooTallNate#1053
118d378
dota17 added a commit to dota17/Java-WebSocket that referenced this issue Aug 1, 2020
@dota17
issue TooTallNate#1053
c73f722
@dota17 dota17 mentioned this issue Aug 1, 2020
Merged
@marci4 marci4 added the Bug label Aug 2, 2020
@marci4 marci4 added this to the Release 1.5.2 milestone Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
Release 1.5.2
Development

Successfully merging a pull request may close this issue.

Fix issue #1053 : Adding check conditions - empty value check dota17/Java-WebSocket
2 participants
@marci4 @dota17