Skip to content

Html Elements Extension #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Html Elements Extension #2158

wants to merge 5 commits into from

Conversation

samllea1
Copy link

@samllea1 samllea1 commented Jun 9, 2025

No description provided.

@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Jun 9, 2025
@CST1229
Copy link
Collaborator

CST1229 commented Jun 9, 2025

you don't have to create a new PR each time you make a change. just push your commits (as in, making them appear on github. if you commit with the web gui this is done automatically) and it will automatically be updated

@samllea1
Copy link
Author

samllea1 commented Jun 9, 2025

you don't have to create a new PR each time you make a change. just push your commits (as in, making them appear on github. if you commit with the web gui this is done automatically) and it will automatically be updated

oh, alr. Im new to this, everything seems so complex. Sorry

Copy link
Contributor

@Brackets-Coder Brackets-Coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only spent a few minutes and kinda skimmed it so I probably missed something but overall this looks really good! Is this your first PR for the repository or am I oblivious to what's happening around here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why you added this license in the root folder?

@@ -0,0 +1,547 @@
// Name: Html Elements
// ID: htmlelements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID should contain your username


getInfo() {
return {
id: "htmlElements",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also contain your username and match the ID above (case-sensitive)

Comment on lines +22 to +25
name: Scratch.translate({
default: "HTML Elements",
id: "htmlElements.name",
}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe I've ever seen the name of an extension have a structure like this, generally speaking shouldn't it just be a translated string?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally the banner should be some sort of artistic representation of the purpose of your extension. Also, they shouldn't contain text as it can't easily be translated. Somebody will probably eventually make a "better" banner anyway so you might not have to worry about it but I would work on a placeholder banner without text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants