Pass request to incident update actions

[jladd-geant]

Scope and purpose

Incident update actions currently dont have any good way to report errors to the UI beyond causing a 500 and can fail silently. This PR passes the request to bulk actions to allow for sending messages to UI when errors occur. geant-argus has bulk actions which interact with external services which can be much less obvious if broken. Also extra checks such as checking for a user's write permission before executing some actions which need to send messages to indicate insufficient permissions in the UI.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

• Added a changelog fragment for towncrier
• Added/amended tests for new/changed code
• Added/changed documentation
• Linted/formatted the code with ruff and djLint, easiest by using pre-commit
• The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (719c987) to head (b9aec97).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/argus/htmx/incident/views.py	0.00%	1 Missing ⚠️
src/argus/htmx/utils.py	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
+ Coverage   79.49%   79.50%   +0.01%     
==========================================
  Files         121      121              
  Lines        5417     5422       +5     
==========================================
+ Hits         4306     4311       +5     
  Misses       1111     1111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[elfjes]

Nice, I like this. Small comment below.

[elfjes]

@jladd-geant what do you want to add to this before marking it as ready?

[jladd-geant]

@jladd-geant what do you want to add to this before marking it as ready?

I will mark it as ready now, was just going over it again to see if I needed to do anything else first.

[hmpf]

I would have preferred sending a message outside of these helpers because then they can be reused in the API but that's probably not gonna happen.

[elfjes]

I would have preferred sending a message outside of these helpers because then they can be reused in the API but that's probably not gonna happen.

Well, we need some way to send a message from the helpers. Perhaps what we could do is to decouple "sending a message" from the django.messages framework, and provide some kind of message callback as an argument into the helper. The implementation of this callback can then be tailored to the environment in which the helper is called. But I would argue that that is out of scope of this PR. There are more things that we need to address before we can use the bulk helpers in the API, especially when considering the pluggability of the bulk helpers

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud