Skip to content

test: reuse UnityChan assets in our sample folder for HdrpGraphicsTest-2022.3 and HdrpGraphicsTest-6000.0 #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2025

Conversation

sindharta
Copy link
Collaborator

No description provided.

sindharta and others added 6 commits June 2, 2025 21:32
(cherry picked from commit 3b4a811)
(cherry picked from commit 10b80fa4eb9a980eef8babe35eb57a0e952c09a5)
(cherry picked from commit 0304e2e)
(cherry picked from commit 50f345cfa22a767c8286133181182133e20be75c)
(cherry picked from commit 6d1ed48)
(cherry picked from commit 8e35e56d5a1501872f76add5e9439e61a0b8cdcc)
(cherry picked from commit 8dc1368)
(cherry picked from commit f7552c8682578d905aa802513dcf30dd593b0747)
@sindharta sindharta force-pushed the reuse-unity-chan-sample4 branch from 89e039f to 2548f9d Compare June 2, 2025 12:33
@sindharta sindharta marked this pull request as ready for review June 5, 2025 06:29
@sindharta sindharta requested review from karasusan and H3idi-X June 6, 2025 07:36
@karasusan
Copy link

karasusan commented Jun 9, 2025

I got the shader error when opening the ToonShader scene in the HdrpGraphicsTest-6000.0 project on Unity Editor 6000.0.50f1.
No error when opening the HdrpGraphicsTest-2022.3 project.

Shader error in 'Toon': undeclared identifier 'unity_MipmapStreaming_DebugTex_ST' at /com.unity.toonshader/TestProjects/HdrpGraphicsTest-6000.0/Library/PackageCache/com.unity.render-pipelines.high-definition@4a7a2c416b77/Runtime/Material/Lit/LitData.hlsl(299) (on d3d11)

Compiling Subshader: 0, Pass: GBuffer, Vertex program with DEBUG_DISPLAY DECALS_3RT
Platform defines: SHADER_API_DESKTOP UNITY_ENABLE_DETAIL_NORMALMAP UNITY_ENABLE_REFLECTION_BUFFERS UNITY_LIGHTMAP_FULL_HDR UNITY_LIGHT_PROBE_PROXY_VOLUME UNITY_PBS_USE_BRDF1 UNITY_PLATFORM_SUPPORTS_DEPTH_FETCH UNITY_SPECCUBE_BLENDING UNITY_SPECCUBE_BOX_PROJECTION UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS
Disabled keywords: DECALS_4RT DECALS_OFF DIRLIGHTMAP_COMBINED DOTS_INSTANCING_ON DYNAMICLIGHTMAP_ON LIGHTMAP_ON LIGHT_LAYERS SHADER_API_GLES30 SHADOWS_SHADOWMASK UNITY_ASTC_NORMALMAP_ENCODING UNITY_COLORSPACE_GAMMA UNITY_FRAMEBUFFER_FETCH_AVAILABLE UNITY_HARDWARE_TIER1 UNITY_HARDWARE_TIER2 UNITY_HARDWARE_TIER3 UNITY_LIGHTMAP_DLDR_ENCODING UNITY_LIGHTMAP_RGBM_ENCODING UNITY_METAL_SHADOWS_USE_POINT_FILTERING UNITY_NO_DXT5nm UNITY_NO_SCREENSPACE_SHADOWS UNITY_PBS_USE_BRDF2 UNITY_PBS_USE_BRDF3 UNITY_PRETRANSFORM_TO_DISPLAY_ORIENTATION UNITY_UNIFIED_SHADER_PRECISION_MODEL UNITY_VIRTUAL_TEXTURING

image

Copy link
Collaborator

@H3idi-X H3idi-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked HdrpGraphicsTest-6000.0 with 6000.0.48f1 and haven't seen that kind of error on my site yet. I think that error should be fixed in other PR for 6000.0.50f1.

Copy link
Collaborator

@H3idi-X H3idi-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce the error using 6000.0.050f1. But I haven't succeeded to reproduced issue.
Screenshot 2025-06-09 at 16 45 26

@sindharta
Copy link
Collaborator Author

@karasusan

I am in favor of H3idi-X's opinion.
Can you try opening with 6000.0.48f1 and see if you still have errors ?

@karasusan
Copy link

karasusan commented Jun 11, 2025

I wish the cause of the issue were my environment, but it reproduced with 6000.0.48f1.
I'll try to remove the library folder and reimport it.
image

It doesn’t reproduce on macOS.

@karasusan
Copy link

We can also reproduce this issue with "development/v1" branch. So, there's no need to fix this issue in this PR.
I'll make a bug ticket for the issue.

@sindharta sindharta merged commit eb7ecd7 into development/v1 Jun 11, 2025
33 checks passed
@sindharta sindharta deleted the reuse-unity-chan-sample4 branch June 11, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants