-
Notifications
You must be signed in to change notification settings - Fork 185
fix(Gallery): fix arrow label #8562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
e2e tests |
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8562/2e51de3330ae8bfbbf7e60cd7d1b31bc5c740479/pkg/@vkontakte/vkui/_pkg.tgz Commit 2e51de3 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8562 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 414 414
Lines 11910 11910
Branches 3939 3939
=======================================
Hits 11419 11419
Misses 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EldarMuhamethanov
approved these changes
May 13, 2025
inomdzhon
approved these changes
May 13, 2025
✅ v7.3.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:cherry-pick:patch
Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e-тестыДизайн-ревьюДокументация фичиОписание
В компоненте карусели не прокидываются свойства лейблов для стрелок
Изменения
Возвращаем эту возможность
Release notes
Исправления
arrowPrevLabel
иarrowNextLabel
не прокидывались к стрелкам