Skip to content

fix(Gallery): fix arrow label #8562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

SevereCloud
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

В компоненте карусели не прокидываются свойства лейблов для стрелок

Изменения

Возвращаем эту возможность

Release notes

Исправления

  • Gallery: свойства arrowPrevLabel и arrowNextLabel не прокидывались к стрелкам

@SevereCloud SevereCloud requested a review from a team as a code owner May 13, 2025 09:56
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 13, 2025
@SevereCloud SevereCloud added this to VKUI May 13, 2025
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI May 13, 2025
@SevereCloud SevereCloud added this to the v7.3.4 milestone May 13, 2025
@SevereCloud SevereCloud self-assigned this May 13, 2025
Copy link
Contributor

size-limit report 📦

Path Size
JS 408.13 KB (+0.04% 🔺)
JS (gzip) 121.51 KB (+0.06% 🔺)
JS (brotli) 99.72 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 349.12 KB (0%)
CSS (gzip) 43.25 KB (0%)
CSS (brotli) 34.51 KB (0%)

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8562/2e51de3330ae8bfbbf7e60cd7d1b31bc5c740479/pkg/@vkontakte/vkui/_pkg.tgz

Commit 2e51de3

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (58c0ec0) to head (2e51de3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8562   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         414      414           
  Lines       11910    11910           
  Branches     3939     3939           
=======================================
  Hits        11419    11419           
  Misses        491      491           
Flag Coverage Δ
unittests 95.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud merged commit a6b388c into master May 14, 2025
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Gallery/fix-arrow-label branch May 14, 2025 09:39
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI May 14, 2025
vkcom-publisher pushed a commit that referenced this pull request May 14, 2025
@vkcom-publisher
Copy link
Contributor

v7.3.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants