-
Notifications
You must be signed in to change notification settings - Fork 185
fix(ChipsSelect): fix onChange with custom fields #8567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
EldarMuhamethanov
merged 1 commit into
master
from
e.muhamethanov/fix-update-custom-select-value
May 15, 2025
Merged
fix(ChipsSelect): fix onChange with custom fields #8567
EldarMuhamethanov
merged 1 commit into
master
from
e.muhamethanov/fix-update-custom-select-value
May 15, 2025
+43
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8567 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 416 416
Lines 11932 11932
Branches 3945 3946 +1
=======================================
Hits 11441 11441
Misses 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8567/aabc216a20ec96870e77eab3ac59392314d5f81f/pkg/@vkontakte/vkui/_pkg.tgz Commit aabc216 |
SevereCloud
approved these changes
May 15, 2025
inomdzhon
approved these changes
May 15, 2025
vkcom-publisher
pushed a commit
that referenced
this pull request
May 15, 2025
✅ v7.3.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:cherry-pick:patch
Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
cmp:chips-input
cmp:chips-select
type:bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
После #8435 появился баг - в
onChange
ChipsSelect
иChipsInput
в values не прокидывались кастомные поля, заданные пользователем вoptions
из-за того, что потерялся spread при расчете новых значений. Вернул spread и написал тест кейсаИзменения
Release notes
Исправления
onChange
не прокидывались кастомные поляoptions