Skip to content

fix(ChipsSelect): fix onChange with custom fields #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Release notes

Описание

После #8435 появился баг - в onChange ChipsSelect и ChipsInput в values не прокидывались кастомные поля, заданные пользователем в options из-за того, что потерялся spread при расчете новых значений. Вернул spread и написал тест кейса

Изменения

Release notes

Исправления

  • ChipsSelect: Поправлен баг с тем, что в onChange не прокидывались кастомные поля options

@EldarMuhamethanov EldarMuhamethanov self-assigned this May 15, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner May 15, 2025 10:02
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 15, 2025
Copy link
Contributor

size-limit report 📦

Path Size
JS 408.73 KB (+0.01% 🔺)
JS (gzip) 121.72 KB (+0.01% 🔺)
JS (brotli) 99.8 KB (-0.13% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 349.12 KB (0%)
CSS (gzip) 43.25 KB (0%)
CSS (brotli) 34.51 KB (0%)

Copy link
Contributor

e2e tests

Playwright Report

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (af5a4e0) to head (aabc216).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8567   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         416      416           
  Lines       11932    11932           
  Branches     3945     3946    +1     
=======================================
  Hits        11441    11441           
  Misses        491      491           
Flag Coverage Δ
unittests 95.88% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8567/aabc216a20ec96870e77eab3ac59392314d5f81f/pkg/@vkontakte/vkui/_pkg.tgz

Commit aabc216

@EldarMuhamethanov EldarMuhamethanov added this to the v7.3.4 milestone May 15, 2025
@EldarMuhamethanov EldarMuhamethanov merged commit 3d90835 into master May 15, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/fix-update-custom-select-value branch May 15, 2025 12:21
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI May 15, 2025
@vkcom-publisher
Copy link
Contributor

v7.3.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча cmp:chips-input cmp:chips-select type:bug
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants