fix(Spinner): icons add className #8568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ci:cherry-pick:patch
EldarMuhamethanov
approved these changes
May 15, 2025
size-limit report 📦
|
e2e tests |
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8568/86d18a9f0bcc684db3ccd7835088192dc405f8e1/pkg/@vkontakte/vkui/_pkg.tgzCommit 86d18a9 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8568 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 416 416
Lines 11932 11934 +2
Branches 3945 3945
=======================================
+ Hits 11441 11443 +2
Misses 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inomdzhon
approved these changes
May 15, 2025
vkcom-publisher
pushed a commit
that referenced
this pull request
May 15, 2025
h2. Описание В коде есть завязки на vkuiIcon классы. В идеале таких завязок не должно быть h2. Release notes h2. Исправления - [Spinner](https://vkcom.github.io/VKUI/${version}/#/Spinner): возвращены vkuiIcon классы
| ✅ v7.3.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
В коде есть завязки на vkuiIcon классы. В идеале таких завязок не должно быть
Release notes
Исправления