Add support for passing decimal refresh rates to gamescope thru the command line #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkautarch
force-pushed
the
decimal_nested_refresh
branch
8 times, most recently
from
279f919 to
a7be015
Compare
sharkautarch
force-pushed
the
decimal_nested_refresh
branch
3 times, most recently
from
e066e99 to
44def3d
Compare
|
I recently edited this PR to use |
sharkautarch
force-pushed
the
decimal_nested_refresh
branch
from
44def3d to
ab5b008
Compare
…o gamescope thru the command line (-r, -o)
sharkautarch
force-pushed
the
decimal_nested_refresh
branch
from
ab5b008 to
ab1ea66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid any floating-point weirdness, I decided to make the code get the whole part and the decimal part of the string arg, convert it to 64 bit unsigned ints, (and also get the length of the decimal part) and do the mathy stuff to calculate the converted-to-mHz value from those integers.
Little bonus is that the code accepts using either a (
,) comma or (.) period as the decimal separator, lol :PI did a little bit of testing to make sure
int32_t ConvertHztomHz( const char* refreshHz )was handling both decimal number-strings and whole-number-strings correctly, and everything just works!