Skip to content

file: revert change in LoadFromFile because of breaking changes #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

makasim
Copy link
Contributor

@makasim makasim commented Jun 3, 2025

This reverts commit 198c85e.

@makasim makasim marked this pull request as ready for review June 3, 2025 06:08
@makasim makasim changed the title Revert "file: load from file should allow configure maxBytes (#86)" file: revert change in LoadFromFile because of breaking changes Jun 3, 2025
@makasim makasim requested a review from zekker6 June 3, 2025 06:09
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.96%. Comparing base (198c85e) to head (8966671).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   76.96%   76.96%           
=======================================
  Files           4        4           
  Lines         547      547           
=======================================
  Hits          421      421           
  Misses         71       71           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makasim makasim merged commit 8cfcf81 into master Jun 3, 2025
7 checks passed
@makasim makasim deleted the load-from-file-revert-bc-break branch June 3, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants