Use -XX:+IProfileDuringStartupPhase in populate_scc.sh scripts
#564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rmnattas
force-pushed
the
scc_IProfileDuringStartupPhase
branch
from
fcf55a1 to
f52d768
Compare
|
@rmnattas Thanks for the PR. The change itself looks fine. Few comments:
|
rmnattas
force-pushed
the
scc_IProfileDuringStartupPhase
branch
from
f52d768 to
b6232c7
Compare
|
Thanks @leochr, updated the PR as requested (changing version 23.0.0.12 and latest only in |
Make use of `-XX:+IProfileDuringStartupPhase` in the `populate_scc.sh` script to enforce collecting IProfile information during JVM startup phase and have more information to store into the SCC. Signed-off-by: Abdulrahman Alattas <[email protected]>
rmnattas
force-pushed
the
scc_IProfileDuringStartupPhase
branch
from
b6232c7 to
3957a24
Compare
|
@leochr Updated the PR to modify 24.0.0.1 and latest instead. Similarly for OpenLiberty/ci.docker#482 |
leochr
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-XX:+IProfileDuringStartupPhaseoption to the populate scc scriptWhen populating the SCC during the build of both the Liberty and app containers, the JVM can disable the IProfiler collection during JVM startup to enhance startup time, but this limits the amount of IProfiler information that can be stored into the SCC.
OpenJ9 can now support
-XX:+IProfileDuringStartupPhaseto enforce collecting IProfiler information during startup and better populate the SCC, which can be used in thepopulate_scc.shscript.The option will be ignored if the used OpenJ9 build does not have the new option implemented.
Effect is larger amount of JIT Data in the SCC after a
populate_sccrun.There’s no functional implications on Liberty, and performance effect is application dependent.
Other than OpenJ9 testing, we have used the option in the
populate_scc.shscript during the CI process of building the containers.OpenJ9 PR: eclipse-openj9/openj9#18381
Corresponding OpenLiberty PR: OpenLiberty/ci.docker#482