Update Curios Implementation (1.20 API) #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VT-14
commented
Sep 28, 2023
VT-14
commented
- Update Dev Environment's Curios API to version 5.3.4-1.20.1.
- Added new Data files to register our "living_armour_socket" slot and set the player to have a Necklace and Charm slot by default, and able to have LA Socket Slots (default size is 0)
- Updated how LA Sockets are added/removed. The old implementation is depreciated and marked for removal in 1.22. Removed the old code.
- Commented out no longer used enqueueIMC in BloodMagic.java.
- Updated LA Socket slot texture to have less contrast.
Curios Slot info is now Data Generated. Bumped Curios version in Gradle Properties. The Socket Upgrade's slot adding/removing features is still very much work-in-progress.
Bump Curios to the latest available 1.20.1 version. Transient modifiers seem to handle relogs better, but is still very buggy.
Lower Contrast to match the current Curios default slot style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.