Fix MI parser to allow async-record w/o a result. #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the async class regex to not require a trailing comma after the class name. Since results are optional, scenarios can exist where there are no results and the regex no longer matches. A new test case has also been added to test the parser for this scenario.
|
Done cleanly, thanks. This reminds me of #305 and the note about testing. hinthint :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339.
This updates the async class regex to not require a trailing comma after
the class name. Since results are optional, scenarios can exist where
there are no results and the regex no longer matches.
A new test case has also been added to test the parser for this
scenario.