improv: code clarity and fixed console selections. #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function SetSelection() in the text editor is used as its name implies to set the part of text that will be shown highlighted as a selection. It has two parameter for the selection start and end. Strangely it also uses a third argument to choose one of 3 selection modes namely line, word and normal. This is strange because it seems that if one wanted to select a line one would simply choose the line start and end as the selection values. As evidence of its strangeness it creates a bug when the word end is selected twice and another when SetSelection is used to set the cursor when the window acquires focus breaking selections in the console. This PR simply eliminates the extraneous argument to SetSelection() ensuring that any problems related to it are fixed once and for all.
…before when it used SetSelection in word mode instead of returning invalid selections when hovering non-word characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function SetSelection() in the text editor is used as its name implies to set the part of text that will be shown highlighted as a selection. It has two parameter for the selection start and end. Strangely it also uses a third argument to choose one of 3 selection modes namely line, word and normal. This is strange because it seems that if one wanted to select a line one would simply choose the line start and end as the selection values. As evidence of its strangeness it creates a bug when the word end is selected twice and another when SetSelection is used to set the cursor when the window acquires focus breaking selections in the console.
This PR simply eliminates the extraneous argument to SetSelection() ensuring that any problems related to it are fixed once and for all.