PHPCS 3.0.0 compatibility.

[mattheu]

The new version of PHP CodeSniffer has some nice features, but introduces breaking changes which mean that the WordPress coding standards are not compatible.

I had a quick look, and I think the minimum required is to namespace the WPCS codebase and import dependencies to ensure everything is autoloaded.

For reference:

• Alpha release notes with more info on new features
• Upgrade guide
• RC1 release notes

[westonruter]

The namespace requirement means we'll need to drop support for PHP 5.2. I'm not heartbroken by that, but Travis builds on PHP 5.2 will need to skip running PHPCS.

[grappler]

It seems they have a minimum requirement as PHP 5.4. Do we know when 3.0 is planned to be released?

[jrfnl]

I'd be cautious of upping the minimum PHPCS to 3.0 for now as other standard libraries - for example PHPCompatibility - which may be used in conjunction with this one may not be compatible with it (yet) and this could cause issues.

Might it be an idea to create a separate PHPCS 3.0 branch (similar to how PHPCS itself is currently doing it) instead for now ?

Do we know when 3.0 is planned to be released?

AFAIK there is no public release planning for the new version, so probably "when it's ready"

[JDGrimes]

I'd be cautious of upping the minimum PHPCS to 3.0 for now as other standard libraries - for example PHPCompatibility - which may be used in conjunction with this one may not be compatible with it (yet) and this could cause issues.

Might it be an idea to create a separate PHPCS 3.0 branch (similar to how PHPCS itself is currently doing it) instead for now ?

That sounds like work. 😄 I'd say wait until 3.0 is actually released, and then plan to be compatible with it in our next release after that. Anybody who needs to use sniffs that aren't compatible with PHPCS 3.0 yet can just use an older version of WPCS for a bit. We can back-port more bugfixes if we want to, but I don't fancy juggling two branches and backporting all new features. If it is worth it to particular folks, of course, they are welcome to do so, but I have a feeling it would just get tedious after a while.

[GaryJones]

I think the consensus is that yes, we want it, but adding it in before 3.0 is released, is not desired.

PHPCS 3.0 RC2 has been tagged, so it won't be long.

[sandrodz]

I'm running phpcs inside docker container, so I need new --basepath= option to run it correctly. Its only available in 3.x version.

Is there any action plan regarding phpcs 3.0 support? thanks.

[jrfnl]

@sandrodz As stated above: once PHPCS 3.0 has been released, i.e. is no longer in alpha/beta/RC.

[jrfnl]

FYI: PHPCS 3.0 has just been released. https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.0.0

[westonruter]

PHPCS 3.0.0 broke WPCS on the core-media-widgets plugin. See xwp/wp-dev-lib#234