-
Notifications
You must be signed in to change notification settings - Fork 12
Attributes on Timestamp #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Let me know of the proposed fix in #20 |
Excellent, worked as needed. New code was
One note - I'm not getting any runtime errors or warnings, but my IDE (PhpStorm) is flagging the first line with Call to 'protected WsSecurity::__construct()' from invalid context Many thanks for the quick response! |
I spoke too soon. On closer inspection of my output, I just noticed that the above code is putting the new Timestamp attribute not just on the Timestamp node but also the parent Security node:
|
Be sure to update the source because I changed it to public (https://github.com/WsdlToPhp/WsSecurity/pull/20/files#diff-30d343eb5cbb31e76a5c333ecb92698fb4d04efd3a486b9b9cddb46c9bb1a62cR14).
Because of your code |
Ah stupid me. Meant to delete that line. Everything is perfect now, thanks again. |
Perfect 😉 |
@agmattzarb you can validate the PR #20 then 😃 |
I merged it too early without waiting the validation, git flow habits... |
The vendor specs I'm writing to are looking for a security header in the format
Note the timestamp includes wsu:Id="Timestamp-XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"
I can't seem to find a way to include this in my output
My code:
results in
How do I go about adding the wsu:Id="Timestamp-" to the Timestamp?
I also haven't figured out a way to get rid of the Expires. If I set the $addExpires param to 0, it removes the entire Timestamp.
The text was updated successfully, but these errors were encountered: