Skip to content

Fix outdated escrow code samples #2787

Open
@mDuo13

Description

@mDuo13

The _code_samples/escrow/js/ folder has several issues:

  • the package.json requires both xrpl.js 3.0 and ripple-lib 0.17 (the latter is ancient and unused in the code). It's likely that ripple-lib is the source of the security issue flagged in chore: upgrade realm version and migrate deprecated config #2783.
  • the samples use the if (typeof module !== "undefined") hack, which is intended to make the same code run in both a browser via html file and in node.js, but they don't have a demo HTML file
  • The samples use hard-coded secrets instead of using the faucet
  • The existing tutorials like Send a Time-Held Escrow use WebSocket requests for sign-and-submit (insecure unless you know what you're doing) instead of signing using the client library

Metadata

Metadata

Assignees

Labels

content updatesUpdating, cleaning up, or rewriting existing content for better usability or new contextsjavascriptPull requests that update Javascript code

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions