Skip to content

Split AccountSet Flags table for better readability #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lanceherman
Copy link

Fixes #2202

Changes

  • Modified the AccountSet Flags table in English documentation
  • Updated the Japanese translation to match
  • No changes were needed for Spanish documentation as it doesn't have this section yet

@lanceherman
Copy link
Author

@mDuo13 @intelliot I have send a PR #3161 . Please review it when you get a chance. Thank You.

Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. It looks much better, with the exception of the parentheses in Japanese (suggestion below for that). It's nice that you made the changes to the Japanese version too, but it does mean we should coordinate with the Japanese-language editors, so I'll wait for word from @tequdev before merging.

| `asfRequireDest` | 1 | `lsfRequireDestTag` | トランザクションをこのアカウントに送信するための宛先タグを要求します。 |
| フラグの名前 | 10進値 | 説明 |
|:----------------------------------|:------|:--------------|
| `asfAccountTxnID` | 5 | このアカウントの直近のトランザクションのIDを追跡します。[AccountTxnID](../common-fields.md#accounttxnid)については必須です。 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes it more obvious that this page hasn't been updated for Clawback. @tequdev @t-ube, how does the following description for asfAllowTrustLineClawback look to you? (I mostly borrowed from the Clawback transaction page.

Suggested change
| `asfAccountTxnID` | 5 | このアカウントの直近のトランザクションのIDを追跡します。[AccountTxnID](../common-fields.md#accounttxnid)については必須です。 |
| `asfAccountTxnID` | 5 | このアカウントの直近のトランザクションのIDを追跡します。[AccountTxnID](../common-fields.md#accounttxnid)については必須です。 |
| `asfAllowTrustLineClawback` | 16 | アカウントの発行したトークンを回収する機能を有効にします。 _[Clawback Amendment][]により追加されました)。_ 既存のトークンを持つ発行者はClawback機能を有効にできません。つまり、トラストライン、オファー、エスクロー、ペイメントチャネル、チェック、または署名者リストを設定する前に行う必要があります。このフラグは、有効にした後は無効にできません。|

Comment on lines +94 to +95
| `asfAccountTxnID` | (なし) |
| `asfAuthorizedNFTokenMinter` | (なし) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks misaligned because we're using two different left-parenthesis characters here, so let's fix that.

Also, adding the asfAllowTrustLineClawback line for consistency with the English version.

Suggested change
| `asfAccountTxnID` | (なし) |
| `asfAuthorizedNFTokenMinter` | (なし) |
| `asfAccountTxnID` | (なし) |
| `asfAllowTrustLineClawback` | `lsfAllowTrustlineClawback` |
| `asfAuthorizedNFTokenMinter` | (なし) |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split AccountSet Flag table into two less-wide tables
2 participants