Skip to content

Unify to single script #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

henningjanssen
Copy link

  • Unified all scripts to a single command-line tool
  • Python3 minor adjustments
  • removed scripts to download firmware as the servers seem to be unmaintenanced

@henningjanssen
Copy link
Author

If you are fine with these changes and want to accept my pull-request, you maybe should notify https://github.com/tripflex/MOD-t

@Xaero252
Copy link
Owner

Sorry for the delay, I'll be reading through this today.
My Mod-T died last year, the control board is toast. I won't be able to test anything.

@henningjanssen
Copy link
Author

Testing on my end is pretty heavy, too, as my Mod-T sometimes won't react to commands other than send_gcode and status and sometimes does not extrude. I hope it does not also die soon as I got it only a few weeks ago.

I basically took your scripts and build a class and argument parser around it as well as adding some braces somewhere at a print.
If you do not want to look into it as you have no use for this code anymore, it's fine.

@Xaero252
Copy link
Owner

Looks good to me.

Definitely a lot nicer to only have 2 files in the repo. I should probably try and figure out what's wrong with my Mod-T (I have a feeling only something in the power section is screwed up, like a missing voltage rail.) I have since also purchased a different printer.

The DFU script is kind of useless without the main modt.py script as is, which is why I wanted to scrap the bash script eventually and just do everything in python. enter DFU, flash the firmware and be done. But there shouldn't be much need to flash firmware now that there is one final firmware and nothing new is likely to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants