Feat(server) add prometheus metrics #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainNeup
force-pushed
the
feat/add-prometheus-metrics
branch
from
24212c4 to
c1954ed
Compare
|
cc @Yooooomi 👋 |
RomainNeup
changed the title
|
Hello, nice idea! I made some work for it to be easier, if you have time to review it before i merge would be great :) |
|
I can't approve but looks good to me :) |
Yooooomi
force-pushed
the
feat/add-prometheus-metrics
branch
from
1efb72c to
0ece3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolve #379, which adds prom-client to the project. The changes include:
Exposing a new endpoint /metrics that displays:
In addition to these custom metrics, the PR also exposes all default Prometheus metrics, including CPU usage, memory usage, and garbage collection (GC) metrics.