UserController loginAction

[j-r-t]

I noticed this in the loginAction

    if ($this->getOptions()->getUseRedirectParameterIfPresent() && $request->getQuery()->get('redirect')) {
        $redirect = $request->getQuery()->get('redirect');
    } else {
        $redirect = false;
    }

shouldn't it be

    if ($this->getOptions()->getUseRedirectParameterIfPresent() && $request->getPost()->get('redirect')) {
        $redirect = $request->getPost()->get('redirect');
    } else {
        $redirect = false;
    }

?. I was having problems with it continually returning false and then realised it should probably be getPost. The login form has a hidden redirect field..upon submit it passes this through post..not string (in regards to the view helper)

eg. $this->ZfcUserLoginWidget(array('redirect'=>'foo');

creates
input type="hidden" name="redirect" value="foo" />

Thanks,

Jesse

[j-r-t]

/**
 * Login form
 */
public function loginAction()
{
    $request = $this->getRequest();
    $form    = $this->getLoginForm();

    if ($this->getOptions()->getUseRedirectParameterIfPresent() && $request->getQuery()->get('redirect')) {
        $redirect = $request->getQuery()->get('redirect');
    } else {
        $redirect = false;
    }

    if (!$request->isPost()) {
        return array(
            'loginForm' => $form,
            'redirect'  => $redirect,
            'enableRegistration' => $this->getOptions()->getEnableRegistration(),
        );
    }

    $form->setData($request->getPost());

    if (!$form->isValid()) {
        if (!$redirect) {
            $postRedirect = $request->getPost()->get('redirect');
            if ($postRedirect) {
                $redirect = $postRedirect;
            }
        }
        $this->flashMessenger()->setNamespace('zfcuser-login-form')->addMessage($this->failedLoginMessage);
        return $this->redirect()->toUrl($this->url()->fromRoute('zfcuser/login').($redirect ? '?redirect='.$redirect : ''));
    }
    // clear adapters

    return $this->forward()->dispatch('zfcuser', array('action' => 'authenticate'));
}

[spiffyjr]

Still having this issue?

https://github.com/ZF-Commons/ZF-Commons/wiki/ZfcUser-1.0-to-2.0-PR-queue-handling (see notes, thanks!)

[flod1]

have the same issue
best way will be:

if ($this->getOptions()->getUseRedirectParameterIfPresent() && $request->getQuery()->get('redirect')) { $redirect = $request->getQuery()->get('redirect'); } elseif ($this->getOptions()->getUseRedirectParameterIfPresent() && $request->getPost()->get('redirect')) { $redirect = $request->getPost()->get('redirect'); } else { $redirect = false; }