Corrupted unzipped files when using Extract

[marcogrcr]

I'm trying to unzip a .zip file containing chromedriver using unzipper@0.10.14. When attempting to unzip chromedriver_linux64.zip downloaded from here, the extraction succeeds, but the executable is corrupted:

$ unzip chromedriver_linux64.zip

$ md5sum chromedriver
ee3dba5202ae87d7b79c22341030db49

$ ./chromedriver
Starting ChromeDriver 111.0.5563.64 (c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}) on port 9515
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.

import { createReadStream } from "node:fs";
import { Extract } from "unzipper";

await createReadStream("chromedriver_linux64.zip")
      .pipe(Extract({ path: "/tmp" }))
      .promise();

Then, when I run:

$ md5sum /tmp/chromedriver
641c5ede222e09e76fe52bc1bc61c0a9

$ /tmp/chromedriver
zsh: permission denied: /tmp/chromedriver

$ chmod +x /tmp/chromedriver

$ /tmp/chromedriver
zsh: exec format error: /tmp/chromedriver

Since I wasn't sure if I was using the .promise() method correctly, I also tried using the equivalent of the README example, but got the same results:

import { createReadStream } from "node:fs";
import { Extract } from "unzipper";

await new Promise((resolve, reject) => {
  createReadStream(driverPkg)
    .pipe(Extract({ path: destinationFolder }))
    .on("close", () => resolve(void 0))
    .on("error", e => reject(e));
});

However, this works just fine with extract-zip@2.0.1:

import extractZip from "extract-zip";

await extractZip("chromedriver_linux64.zip", { dir: "/tmp" })

Then, when I run:

$ md5sum chromedriver
ee3dba5202ae87d7b79c22341030db49

$ /tmp/chromedriver
Starting ChromeDriver 111.0.5563.64 (c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}) on port 9515
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.

[vincent-seibus]

hello ,

I have got the same issue, when I extract a zip on linux debian , I have got the javascript files inside my zip that have been modified.

[couturecraigj]

+1

[Toliak]

Same issue on Windows 11

Is related to #271

[dgdosen]

same issue when run from macos...

[jarlah]

same problem here. in a linux docker image in openshift ...

[PeterSelvaraj]

I ran into this issue. After much research, this appears to be an issue brought on by changes in NodeJS. I was using 18.18.0 when I ran into the issue. Downgrading to v18.15.0 solved the problem. The issue exists in v18.16.0 and above.

[marcogrcr]

Wow @PeterSelvaraj you nailed it, well done and thanks for the hard work! I can confirm this is the case in MacOS 13.5.2.

I'm installing node using asdf and tested chromedriver_mac_arm64.zip:

% unzip chromedriver_mac_arm64.zip 
Archive:  chromedriver_mac_arm64.zip
  inflating: chromedriver            
  inflating: LICENSE.chromedriver

% md5 chromedriver
MD5 (chromedriver) = 5e4ba0b62a072ff281fe9fc769d8665a

Then run:

import { createReadStream, readFileSync } from "node:fs";
import { Extract } from "unzipper";
import { createHash } from "node:crypto";

// version
console.log("Node.js version:", process.versions.node);

// unzipper
await createReadStream("chromedriver_mac_arm64.zip")
      .pipe(Extract({ path: "." }))
      .promise();

// MD5
const buffer = readFileSync("chromedriver");
const md5 = createHash("md5");
md5.write(buffer);
console.log("MD5:", md5.digest().toString("hex"));

Then playing with the .tool-versions => nodejs X.X.X

node@19 worked for some time and then stopped working, node@20 has never worked:

Version range	Tested versions	MD5	OK?
18.13.0-18.15.0	18.13.0, 18.14.0, 18.14.1, 18.14.2, 18.15.0	5e4ba0b62a072ff281fe9fc769d8665a	Yes
18.16.0-18.18.0	18.16.0, 18.16.1, 18.17.0, 18.17.1, 18.18.0	4b4e65d5c6b824db4898cb070b600c19	No
19.0.0-19.7.0	19.0.0, 19.0.1, 19.1.0, 19.2.0, 19.3.0, 19.4.0, 19.5.0, 19.6.0, 19.6.1, 19.7.0	5e4ba0b62a072ff281fe9fc769d8665a	Yes
19.8.0-19.9.0	19.8.0, 19.8.1, 19.9.0	4b4e65d5c6b824db4898cb070b600c19	No
20.0.0-20.8.0	20.0.0, 20.1.0, 20.2.0, 20.3.0, 20.3.1, 20.4.0, 2.5.0, 20.5.1, 20.6.0, 20.6.1, 20.7.0, 20.8.0	4b4e65d5c6b824db4898cb070b600c19	No

[Fadorico]

I came upon this issue after having done quite a bit of investigation myself on some problems we were having in our app. I found that this is the exact commit in NodeJS that broke it: nodejs/node@654b747

I essentially built NodeJS from source and did a checkout of commits to see when stuff breaks and when it doesn't