fix: Themed breakpoint not being applied #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 72 72
Branches 17 17
=====================================
Hits 72 72
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 72 78 +6
Branches 17 20 +3
=====================================
+ Hits 72 78 +6
Continue to review full report at Codecov.
|
added 7 commits
July 15, 2017 23:24
This reverts commit 37f4378.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #61
Properly includes the breakpoint value when creating the media queries.
Help wanted:
Currently, with the way I am passing the template string as the second argument it now includes commas separating the string and the values, I'm having to now split on comma and rejoin. this is a very hacky solution.