Removed extraneous semicolons to make jest-styled-components ^4.3.0 happy #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 82 82
Branches 20 20
=====================================
Hits 82 82
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Aaron, long time follower, first time committer!
I'm using jest-styled-components to enable jest snapshot testing for components using styled-components. As of 4.3.0, it seems quite pedantic about things like extraneous semicolons in the resulting stylesheet. I think the issue with the semicolons would be similar to this issue over on the jest-styled-components project.
I debugged and found that
Row.jsandCol.jsboth had a couple of extraneous semicolons that would result in styles of{;}in the final stylesheet which caused parsing issues for jest-styled-components.PR for your consideration, thanks.