Fix package/dependency creation bugs #2932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jono Yang <[email protected]>
Fixes #2928 in pypi and others which were being caused by infinite recursion between the functions `assign_package_to_parent_tree` and `assign_package_to_resources` because of improper overriding. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Fixes #2911 Do not create top level dependencies in case of dependencies without purls, these are encountered in pypi requirements with local paths. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
…2911-purl-less-deps
pombredanne
reviewed
Apr 29, 2022
pombredanne
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
LGTM!
I just have a small comment wrt. https://github.com/nexB/scancode-toolkit/pull/2932/files#r861907921 where subclassing is not needed especially since you call super() which will travel up the class hierarchy and MRO alright
Call resource updating functions directly from models.DatafileHandler instead of calling super(). Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
|
@pombredanne updated that. |
Try and catch failures in top level packages and dependencies creation, and add them to resource level `scan_errors`, instead of crashing. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
with git add --force Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
There is still a pending bug. See: #2934 Signed-off-by: Philippe Ombredanne <[email protected]>
|
LGTM. Thanks! merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Run tests locally to check for errors.