Added a validation check to raise an error if a directory is passed to the --from-json option #4033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the --from-json option Signed-off-by: Aayush Kumar <[email protected]>
… in JSON checks Signed-off-by: Aayush Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3592
When the --from-json option is used, it currently allows directories as input, resulting in a crash. This issue was initially addressed in PR #3609, but the fix did not fully resolve the problem. As a result, the tool continues to crash when directories are passed to --from-json.
This PR aims to resolve the issue by adding validation checks for directories.
Tasks
Run tests locally to check for errors.