Skip to content

Monorepo : added rest-client & rest-express to the monorepo #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2018

Conversation

Aetherall
Copy link
Member

No description provided.

@pradel
Copy link
Member

pradel commented Mar 11, 2018

Looks like codecov didn't work for that pr 🤔 https://codecov.io/gh/accounts-js/accounts/pulls

@Aetherall
Copy link
Member Author

Strange, It does see the branch with the commits
https://codecov.io/gh/accounts-js/accounts/branch/monorepo%2Frest

@pradel
Copy link
Member

pradel commented Mar 11, 2018

Does not really matter the coverage is 92+% on that branch

"author": "Tim Mikeladze",
"license": "MIT",
"devDependencies": {
"@accounts/common": "0.1.0-beta.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the types definitions are missing there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originaly:

"devDependencies": {
    "@accounts/common": "0.1.0-beta.3",
    "@accounts/server": "0.1.0-beta.3",
    "@types/express": "4.11.1",
    "@types/lodash": "4.14.104",
    "@types/request-ip": "0.0.33"
  },

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed :)

@codecov-io
Copy link

Codecov Report

Merging #169 into master will increase coverage by 1.82%.
The diff coverage is 99.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   90.34%   92.16%   +1.82%     
==========================================
  Files          26       42      +16     
  Lines         818     1034     +216     
  Branches      113      124      +11     
==========================================
+ Hits          739      953     +214     
- Misses         69       70       +1     
- Partials       10       11       +1
Impacted Files Coverage Δ
...kages/rest-express/src/endpoints/password/reset.ts 100% <100%> (ø)
...es/rest-express/src/endpoints/password/register.ts 100% <100%> (ø)
...rest-express/src/endpoints/refresh-access-token.ts 100% <100%> (ø)
packages/rest-express/src/express-middleware.ts 100% <100%> (ø)
packages/rest-express/src/user-loader.ts 100% <100%> (ø)
packages/rest-express/src/endpoints/impersonate.ts 100% <100%> (ø)
packages/rest-express/src/endpoints/logout.ts 100% <100%> (ø)
packages/rest-express/src/utils/get-user-agent.ts 100% <100%> (ø)
packages/rest-express/src/index.ts 100% <100%> (ø)
packages/rest-express/src/endpoints/get-user.ts 100% <100%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e55ef...4e70296. Read the comment docs.

@pradel
Copy link
Member

pradel commented Mar 12, 2018

Thanks @Aetherall

@pradel pradel merged commit d4ac424 into master Mar 12, 2018
@pradel pradel deleted the monorepo/rest branch March 12, 2018 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants