-
-
Notifications
You must be signed in to change notification settings - Fork 140
Monorepo : added rest-client & rest-express to the monorepo #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like codecov didn't work for that pr 🤔 https://codecov.io/gh/accounts-js/accounts/pulls |
Strange, It does see the branch with the commits |
Does not really matter the coverage is 92+% on that branch |
"author": "Tim Mikeladze", | ||
"license": "MIT", | ||
"devDependencies": { | ||
"@accounts/common": "0.1.0-beta.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the types definitions are missing there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
originaly:
"devDependencies": {
"@accounts/common": "0.1.0-beta.3",
"@accounts/server": "0.1.0-beta.3",
"@types/express": "4.11.1",
"@types/lodash": "4.14.104",
"@types/request-ip": "0.0.33"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fixed :)
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 90.34% 92.16% +1.82%
==========================================
Files 26 42 +16
Lines 818 1034 +216
Branches 113 124 +11
==========================================
+ Hits 739 953 +214
- Misses 69 70 +1
- Partials 10 11 +1
Continue to review full report at Codecov.
|
Thanks @Aetherall |
No description provided.