Fix Palo Alto commit to be a partial admin-focused commit #4198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue acmesh-official#4197 -- Commit currently commits all pending changes to the firewall, which could be very, very bad. This changes to commit to a partial commit of just the admin user acme.sh is using, which should be a dedicated admin user and not shared by anything else.
Hossy
changed the title
|
@Neilpang Please review and merge/provide feedback |
sg1888
pushed a commit
to sg1888/acme.sh
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4197 -- Commit currently commits all pending changes to the firewall, which could be very, very bad. This changes to commit to a partial commit of just the admin user acme.sh is using, which should be a dedicated admin user and not shared by anything else.