Skip to content

dns_1984.hosting.sh: fix login with valid csrftoken #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

phedoreanu
Copy link
Contributor

Fixed broken login by adding valid csrftoken.

See this for details.

@github-actions
Copy link

Welcome
Please make sure you're read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch from ec89e6a to 30cf11b Compare November 26, 2022 19:20
@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch from 30cf11b to cebe558 Compare November 26, 2022 19:38
@Neilpang
Copy link
Member

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch 7 times, most recently from fc72ba8 to adc4390 Compare November 27, 2022 09:15
@howaboutlollmao
Copy link

howaboutlollmao commented Nov 30, 2022

Fails on Linux as well, debug logs show the token as empty string (csrf_token: ''). Replacing the functions like _egrep_o with actual commands worked, so the procedure itself is fine.

@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch 16 times, most recently from f64bdc7 to cfdbd1f Compare December 20, 2022 19:43
@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch from 6b0fb69 to 2f69885 Compare January 31, 2023 09:56
@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch from 2f69885 to b9f0488 Compare February 9, 2023 20:05
@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch 2 times, most recently from 6237069 to c41f34d Compare February 20, 2023 10:53
@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch 2 times, most recently from 4e18cc8 to 2b31e47 Compare March 3, 2023 14:01
@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch 4 times, most recently from 3149278 to ffea264 Compare May 17, 2023 07:13
@phedoreanu
Copy link
Contributor Author

@phedoreanu phedoreanu changed the title dns_1984hosting.sh: fix login with valid csrftoken dns_1984.hosting.sh: fix login with valid csrftoken May 24, 2023
@phedoreanu phedoreanu force-pushed the bugfix/1984_hosting_csrftoken branch from ffea264 to 0d04782 Compare June 11, 2023 13:22
@Neilpang Neilpang merged commit 7d50332 into acmesh-official:dev Jun 11, 2023
@phedoreanu phedoreanu deleted the bugfix/1984_hosting_csrftoken branch June 11, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants