feat: reset referral rewards after claim #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amateima
commented
Dec 19, 2022
Comment on lines
+8
to
+10
| create index "IX_deposit_srAddress_depositDate_pId_tId_status" | ||
| on deposit ("stickyReferralAddress", "depositDate", "priceId", "tokenId", status) | ||
| `); |
There was a problem hiding this comment.
This index will help to get the deposits faster when using these fields in the WHERE clause
james-a-morris
approved these changes
Dec 19, 2022
pxrl
reviewed
Dec 20, 2022
| @@ -0,0 +1,16 @@ | |||
| import { MigrationInterface, QueryRunner } from "typeorm"; | |||
|
|
|||
| export class Deposit1671299400000 implements MigrationInterface { | |||
There was a problem hiding this comment.
Just curious: what's the significance of this timestamp?
date -u -r 1671299400
Sat Dec 17 17:50:00 UTC 2022
There was a problem hiding this comment.
this is the timestamp when the migration file was created. The migration files contain the queries that define the structure of the database: creating tables, adding columns, altering tables, etc, so it's crucial for the migration files to run chronologically
amateima
added a commit
that referenced
this pull request
Dec 20, 2022
amateima
deleted the
amatei/acx-502-fix-the-reset-of-referral-rate-after
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic for computing the referral rewards by grouping the deposits by the Claim events.