Skip to content

Introduce new preview auto-scaling mode for ARC. #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

TingluoHuang
Copy link
Member

As mentioned in #2072, we are trying to introduce a new auto-scaling mode to ARC and hope to improve the following areas:

  • No longer require cert-manager as a pre-requirement for using ARC.
  • Reliable scale down to zero runner pod and scale up based on job demands.
  • Reduce API requests to api.github.com in order to avoid rate-limiting.
  • No longer pass your GitHub admin privilege token to the runner pod for runner registration.
  • Max flexibility on customizing your runner pod template.
  • Unify ARC installation process to helm charts.

The preview auto-scaling mode introduced in this PR requires certain new APIs on GitHub.com.
Those new APIs are behind a feature flag which is OFF right now, we will run through a set of testing before turning on the feature flag for everyone.

TLDR: You can't use this new auto-scaling mode now with your GitHub enterprise/organization/repository

@TingluoHuang TingluoHuang requested review from mumoshu, toast-gear and a team as code owners January 13, 2023 16:30
@Link-
Copy link
Member

Link- commented Jan 16, 2023

TODO before merge

@TingluoHuang TingluoHuang force-pushed the autoscalingrunnerset branch 6 times, most recently from c1dd24e to 42b8d8d Compare January 17, 2023 15:04
@TingluoHuang TingluoHuang force-pushed the autoscalingrunnerset branch 2 times, most recently from d0c201a to dbde5c6 Compare January 17, 2023 16:30
Link-
Link- previously approved these changes Jan 17, 2023
Copy link
Member

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Co-authored-by: Cory Miller <[email protected]>
Co-authored-by: Nikola Jokic <[email protected]>
Co-authored-by: Ava Stancu <[email protected]>
Co-authored-by: Ferenc Hammerl <[email protected]>
Co-authored-by: Francesco Renzi <[email protected]>
Co-authored-by: Bassem Dghaidi <[email protected]>
@TingluoHuang TingluoHuang merged commit 622eaa3 into master Jan 17, 2023
@TingluoHuang TingluoHuang deleted the autoscalingrunnerset branch January 17, 2023 17:06
@ajschmidt8
Copy link
Contributor

🚀🚀🚀

looking forward to this being publicly available!!

@AlonAvrahami
Copy link

You guys rock! 🚀 can't wait! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants