-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Introduce new preview auto-scaling mode for ARC. #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link-
reviewed
Jan 16, 2023
TODO before merge
|
c1dd24e
to
42b8d8d
Compare
d0c201a
to
dbde5c6
Compare
Link-
previously approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Cory Miller <[email protected]> Co-authored-by: Nikola Jokic <[email protected]> Co-authored-by: Ava Stancu <[email protected]> Co-authored-by: Ferenc Hammerl <[email protected]> Co-authored-by: Francesco Renzi <[email protected]> Co-authored-by: Bassem Dghaidi <[email protected]>
dbde5c6
to
c7e111c
Compare
Link-
approved these changes
Jan 17, 2023
🚀🚀🚀 looking forward to this being publicly available!! |
You guys rock! 🚀 can't wait! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2072, we are trying to introduce a new auto-scaling mode to ARC and hope to improve the following areas:
cert-manager
as a pre-requirement for using ARC.api.github.com
in order to avoid rate-limiting.The preview auto-scaling mode introduced in this PR requires certain new APIs on GitHub.com.
Those new APIs are behind a feature flag which is
OFF
right now, we will run through a set of testing before turning on the feature flag for everyone.TLDR: You can't use this new auto-scaling mode now with your GitHub enterprise/organization/repository