Skip to content

Constructor is setting a digital pin before setting OUTPUT mode. #49

Open
@ghost

Description

In the constructor
Adafruit_TFTLCD::Adafruit_TFTLCD(uint8_t cs, uint8_t cd, uint8_t wr, uint8_t rd, uint8_t reset)

we see the following lines of code:

  if (reset) {
    digitalWrite(reset, HIGH);
    pinMode(reset, OUTPUT);
  }

Is it valid to be setting the line to HIGH before the pinMode is set? On SAMD51 the default pin mode is INPUT_PULLUP.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions