-
Notifications
You must be signed in to change notification settings - Fork 225
chore: remove spectrum-config.js files from various packages #5417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a question about the ui-icons package (which is an svg resource and not CSS). Otherwise, this looks good!
This PR includes your updates as well so I could validate my work: https://github.com/adobe/spectrum-web-components/pull/5419/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
* chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]>
…tion (#5472) * chore: remove spectrum-config.js files from various packages (#5417) * chore: remove spectrum-config.js files from various packages * chore; remove spectrum-css dependencies * chore: remove unused @spectrum-css dependencies from yarn.lock * Update packages/icons-ui/package.json * Update packages/icons-ui/package.json --------- Co-authored-by: Casey Eickhoff <[email protected]> * chore: update styling guide (#5437) * chore: add styling guide * chore: remove spectrum-config and update other docs * fix: update yarn new-package to not depend on spectrum-css * chore: update styling guide * chore: remove formating from plopfile * chore: update grammer nits Co-authored-by: rise-erpelding <[email protected]> * chore: update docs grammer Co-authored-by: rise-erpelding <[email protected]> * chore: remove unnecessary file generation during new-packge * chore: remove spectrum-config from the generate-component doc * chore: process-spectrum part 1 [swc-808] * chore: include version alignment into constraints [swc-809] * chore: clean-up unused packages * chore: move tasks into scripts [swc-854] (#5476) * chore: move tasks into scripts [swc-854] * chore: update custom element manifest scripts to simpify * chore: remove build-confirm command and fix cem-tools (#5482) * chore: remove build-confirm command and fix cem-tools * chore: adds build confirm command back --------- Co-authored-by: Casey Eickhoff <[email protected]> * chore: addressing feedback * chore: fix new-package command and more feedback * chore: add back args and template plops * chore: spectrum config search feedback * chore: addressing feedback * chore: addressing feedback * chore: addressing feedback * chore: addressing feedback * chore: addressing feedback * chore: update renovate config * update capitalization Co-authored-by: Josh Johnson <[email protected]> * update copywright Co-authored-by: Josh Johnson <[email protected]> * chore: update capitalization again Co-authored-by: Josh Johnson <[email protected]> --------- Co-authored-by: Piyush Vashisht <[email protected]> Co-authored-by: TaraT <[email protected]> Co-authored-by: rise-erpelding <[email protected]> Co-authored-by: castastrophe <[email protected]> Co-authored-by: Josh Johnson <[email protected]>
Description
This PR removes all spectrum-config.js files and @spectrum-css dependencies from component package.json files as we are now maintaining styles directly within SWC.
Changes
Removed all spectrum-config.js files across component packages
Removed @spectrum-css dependencies from all component package.json files
Ensured no references to @spectrum-css remain in the codebase (outside of documentation which will be addressed in SWC-811)
Testing
Verified all instances are removed by running the following search queries:
Searched for spectrum-config (excluding .git, node_modules, .wireit, .html, CHANGELOG.md, changelog-content.md, yarn.lock, .changeset)
Searched for @spectrum-css (excluding .git, node_modules, .wireit, .html, CHANGELOG.md, changelog-content.md, yarn.lock, .changeset)
Related issue(s)
Motivation and context
How has this been tested?
Test case 1
Test case 2
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.