Skip to content

chore: remove spectrum-config.js files from various packages #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 1, 2025

Conversation

blunteshwar
Copy link
Contributor

@blunteshwar blunteshwar commented Apr 30, 2025

Description

This PR removes all spectrum-config.js files and @spectrum-css dependencies from component package.json files as we are now maintaining styles directly within SWC.

Changes

Removed all spectrum-config.js files across component packages
Removed @spectrum-css dependencies from all component package.json files
Ensured no references to @spectrum-css remain in the codebase (outside of documentation which will be addressed in SWC-811)

Testing

Verified all instances are removed by running the following search queries:
Searched for spectrum-config (excluding .git, node_modules, .wireit, .html, CHANGELOG.md, changelog-content.md, yarn.lock, .changeset)
Searched for @spectrum-css (excluding .git, node_modules, .wireit, .html, CHANGELOG.md, changelog-content.md, yarn.lock, .changeset)

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@blunteshwar blunteshwar requested a review from a team as a code owner April 30, 2025 06:11
Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: ce30a64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question about the ui-icons package (which is an svg resource and not CSS). Otherwise, this looks good!

@castastrophe
Copy link
Contributor

This PR includes your updates as well so I could validate my work: https://github.com/adobe/spectrum-web-components/pull/5419/files

Copy link
Contributor

@caseyisonit caseyisonit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@caseyisonit caseyisonit merged commit c20587b into CSS-Cutoff May 1, 2025
3 of 22 checks passed
@caseyisonit caseyisonit deleted the pvashish/SWC-810 branch May 1, 2025 15:15
castastrophe pushed a commit that referenced this pull request May 1, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 5, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 6, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 6, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 8, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 9, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 9, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 9, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 12, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 13, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
castastrophe pushed a commit that referenced this pull request May 16, 2025
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>
caseyisonit added a commit that referenced this pull request May 21, 2025
…tion (#5472)

* chore: remove spectrum-config.js files from various packages (#5417)
* chore: remove spectrum-config.js files from various packages
* chore; remove spectrum-css dependencies
* chore: remove unused @spectrum-css dependencies from yarn.lock
* Update packages/icons-ui/package.json
* Update packages/icons-ui/package.json

---------

Co-authored-by: Casey Eickhoff <[email protected]>

* chore: update styling guide (#5437)

* chore: add styling guide

* chore: remove spectrum-config and update other docs

* fix: update yarn new-package to not depend on spectrum-css

* chore: update styling guide

* chore: remove formating from plopfile

* chore: update grammer nits

Co-authored-by: rise-erpelding <[email protected]>

* chore: update docs grammer

Co-authored-by: rise-erpelding <[email protected]>

* chore: remove unnecessary file generation during new-packge

* chore: remove spectrum-config from the generate-component doc

* chore: process-spectrum part 1 [swc-808]

* chore: include version alignment into constraints [swc-809]

* chore: clean-up unused packages

* chore: move tasks into scripts [swc-854] (#5476)

* chore: move tasks into scripts [swc-854]

* chore: update custom element manifest scripts to simpify

* chore: remove build-confirm command and fix cem-tools (#5482)

* chore: remove build-confirm command and fix cem-tools

* chore: adds build confirm command back

---------

Co-authored-by: Casey Eickhoff <[email protected]>

* chore: addressing feedback

* chore: fix new-package command and more feedback

* chore: add back args and template plops

* chore: spectrum config search feedback

* chore: addressing feedback

* chore: addressing feedback

* chore: addressing feedback

* chore: addressing feedback

* chore: addressing feedback

* chore: update renovate config

* update capitalization

Co-authored-by: Josh Johnson <[email protected]>

* update copywright

Co-authored-by: Josh Johnson <[email protected]>

* chore: update capitalization again

Co-authored-by: Josh Johnson <[email protected]>

---------

Co-authored-by: Piyush Vashisht <[email protected]>
Co-authored-by: TaraT <[email protected]>
Co-authored-by: rise-erpelding <[email protected]>
Co-authored-by: castastrophe <[email protected]>
Co-authored-by: Josh Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants