Skip to content

Fix OpenAPI specs #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 28, 2024
Merged

Fix OpenAPI specs #390

merged 11 commits into from
Apr 28, 2024

Conversation

Petitoto
Copy link
Member

@Petitoto Petitoto commented Mar 30, 2024

Description

This PR fixes OpenAPI specs, with the aim to be fully compatible with several API clients like Hoppscotch.

This includes:

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

Breaking change

Remove PostmanAuthClient

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.45%. Comparing base (3a87006) to head (f36c8e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   80.43%   80.45%   +0.02%     
==========================================
  Files          85       85              
  Lines        5790     5797       +7     
==========================================
+ Hits         4657     4664       +7     
  Misses       1133     1133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@julien4215 julien4215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we moving versions numbers and code to .env ? (see Armand's comment below)

In my opinion these fields should be hardcoded and not based on the dotenv. The MINIMAL_TITAN_VERSION_CODE is known during development and not deployement.

Copy link
Member

@armanddidierjean armanddidierjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks @Petitoto!

This reverts commit ee3a5bc.

# Conflicts:
#	app/utils/auth/providers.py
@julien4215 julien4215 merged commit 08d215a into main Apr 28, 2024
@julien4215 julien4215 deleted the fix-openapi-specs branch April 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants