-
Notifications
You must be signed in to change notification settings - Fork 8
Fix OpenAPI specs #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenAPI specs #390
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 80.43% 80.45% +0.02%
==========================================
Files 85 85
Lines 5790 5797 +7
==========================================
+ Hits 4657 4664 +7
Misses 1133 1133 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we moving versions numbers and code to .env ? (see Armand's comment below)
In my opinion these fields should be hardcoded and not based on the dotenv. The MINIMAL_TITAN_VERSION_CODE is known during development and not deployement.
dec3a49
to
ae5e734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks @Petitoto!
This reverts commit ee3a5bc. # Conflicts: # app/utils/auth/providers.py
Description
This PR fixes OpenAPI specs, with the aim to be fully compatible with several API clients like Hoppscotch.
This includes:
/
(see https://learn.openapis.org/specification/paths.html#the-endpoints-list)^[a-zA-Z0-9\.\-_]+$
(see https://spec.openapis.org/oas/latest.html#fixed-fields-5)HYPERION_VERSION
andMINIMAL_TITAN_VERSION_CODE
to .envChecklist
Breaking change
Remove
PostmanAuthClient