Skip to content

Update to standard-library 1.7.1 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Nov 22, 2021

No description provided.

@JacquesCarette
Copy link
Collaborator

Apparently it's not that simple?

@iblech
Copy link
Contributor Author

iblech commented Nov 22, 2021

It is :-) You can test it using:

nix-shell -I nixpkgs=https://github.com/iblech/nixpkgs/archive/patch-agda-stdlib1.7.1.tar.gz -p "agda.withPackages (p: [ p.standard-library p.agda-categories ])"

The CI only fails because it does not yet have stdlib 1.7.1 available, which was only released today.

(This pull request is a dependence of a pull request for NixOS, NixOS/nixpkgs#147061.)

@JacquesCarette
Copy link
Collaborator

I saw that 1.7.1 was released just earlier today - I was just under the impression that the CI would grab the latest. If it doesn't, then something else needs adjusted too, so that CI passes.

@turion
Copy link
Contributor

turion commented Nov 23, 2021

I think you need to bump the STDLIB_VERSION variable in github actions as well:

Otherwise CI will always pull the specific version 1.7

@MatthewDaggitt
Copy link
Contributor

Just a heads up that upgrading to this release is purely optional. Doesn't change any actual Agda code, only makes the cabal file compatible with GHC 9.2 (hence why it hasn't been announced).

@JacquesCarette
Copy link
Collaborator

I wasn't going to upgrade, but I also won't refuse a ready-made PR that makes it all work!

@iblech
Copy link
Contributor Author

iblech commented Nov 23, 2021

@MatthewDaggitt Thank you for the pointer! I force-pushed to my branch. Let's see what the CI will make of this! :-)

@JacquesCarette
Copy link
Collaborator

The CI liked it. I'm still vaguely reluctant. Opinions?

@turion
Copy link
Contributor

turion commented Nov 24, 2021

My two cents: If you merge it you'd have to bump (and eventually release) the agda-categories version as well, since it will not be compatible with standard-library-1.7 anymore.

@MatthewDaggitt
Copy link
Contributor

Ah, the perils of making our first backwards compatible release. We realise we don't have any mechanism for compatible versioning management 😆

@iblech
Copy link
Contributor Author

iblech commented Nov 29, 2021

Hm... yes indeed. Any thoughts on that? We could also patch agda-categories locally in nixpkgs.

@turion
Copy link
Contributor

turion commented Nov 29, 2021

I think you should merge and bump agda-categories. Releases are simple to download, so people can stay with 1.7 if that's important to them.

@JacquesCarette
Copy link
Collaborator

I'm going to pull in a few more PRs first, and then merge-and-bump.

@pthariensflame
Copy link

Is this in process still?

@JacquesCarette
Copy link
Collaborator

The PRs that I wanted to pull in are in. I just have not had any time to devote to this in the last few weeks. Looks like the next 2 weeks are also a disaster, but clear up after that. I'd be happy to get a co-maintainer though from the people who have submitted many PRs previously, such as @TOTBWF or @sstucki .

@TOTBWF
Copy link
Collaborator

TOTBWF commented Mar 6, 2022

I'd be more than happy to help out!

@JacquesCarette
Copy link
Collaborator

I'd be more than happy to help out!

Great - see your email for more.

@JacquesCarette JacquesCarette merged commit 1617a2d into agda:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants