Skip to content

Improve level polymorphism in one place. #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Improve level polymorphism in one place. #380

merged 1 commit into from
Jul 25, 2023

Conversation

JacquesCarette
Copy link
Collaborator

@xplat noticed that the product construction could have more general Levels. Also use variables a bit more while at it.

…Levels. Also use variables a bit more while at it.
@JacquesCarette JacquesCarette requested a review from Taneb July 25, 2023 02:35
Copy link
Member

@Taneb Taneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JacquesCarette JacquesCarette merged commit 36abe6b into master Jul 25, 2023
@JacquesCarette JacquesCarette deleted the product branch July 25, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants