Skip to content

Graded monads #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Graded monads #390

merged 2 commits into from
Sep 18, 2023

Conversation

sstucki
Copy link
Collaborator

@sstucki sstucki commented Aug 22, 2023

Apparently, I wrote this a year ago but forgot to submit a PR. It's been sitting on a stale branch in my fork of the repo for a year so it needs to be properly rebased before it's ready to be merged. In particular, the first commit (6e5e05e) will become redundant once #389 has been merged.

@JacquesCarette
Copy link
Collaborator

Thanks for GradedMonad, I'm eager to merge that in. I'm not keen on using 'prime' for the name of the alternate definition. Can we try to find a better one? Would KlesliGradedMonad be appropriate?

@sstucki
Copy link
Collaborator Author

sstucki commented Aug 23, 2023

I'm not keen on using 'prime' for the name of the alternate definition. Can we try to find a better one? Would KlesliGradedMonad be appropriate?

I agree the current naming isn't great. How about GradedKleisliTriple? That would be consistent with the naming we use for the non-graded case:

KleisliTriple : Set (o ⊔ ℓ ⊔ e)

I'm fine with either suggestion, really.

@JacquesCarette
Copy link
Collaborator

I prefer GradedKleisliTriple, it is more consistent.

@sstucki
Copy link
Collaborator Author

sstucki commented Sep 5, 2023

I've rebased the old commits on the latest master and fixed the name of the alternate definition to GradedKleisliTriple as agreed, so this is basically ready to be merged now. I'm just waiting on #389 (not sure what the status is there).

@sstucki sstucki changed the title [draft] Graded monads Graded monads Sep 5, 2023
Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny improvement, and this is ready to go - thanks.

@sstucki
Copy link
Collaborator Author

sstucki commented Sep 17, 2023

@JacquesCarette, I fixed Endofuctors.agda as you suggested, although I thought that file would be replaced by #389, once it was ready. I'm not sure what the status of #389 is, the authors haven't replied to the requests for changes, so I'll leave it up to you if you want to wait for that PR to be fixed, or merge the version from this PR instead (that would make #389 obsolete).

@JacquesCarette
Copy link
Collaborator

This has waited long enough - I'll merge this in as it is ready.

@JacquesCarette JacquesCarette merged commit 0947948 into agda:master Sep 18, 2023
@sstucki sstucki deleted the graded-monads branch September 19, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants